Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module:all): remove the backdrop of most components #5925

Merged
merged 3 commits into from
Oct 21, 2020

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Oct 15, 2020

related components: cascader, datepicker, timepicker, popconfirm, popover, select, treeselect.
@angular/cdk >= 10.1.0

close #4763
close #5061
close #4259
close #2508

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Oct 15, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #5925 into master will decrease coverage by 0.06%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5925      +/-   ##
==========================================
- Coverage   90.00%   89.93%   -0.07%     
==========================================
  Files         463      463              
  Lines       13949    13965      +16     
  Branches     2283     2289       +6     
==========================================
+ Hits        12555    12560       +5     
- Misses        858      866       +8     
- Partials      536      539       +3     
Impacted Files Coverage Δ
components/popconfirm/popconfirm.ts 100.00% <ø> (ø)
components/popover/popover.ts 92.85% <ø> (ø)
components/tooltip/tooltip.ts 100.00% <ø> (ø)
components/select/select.component.ts 87.11% <33.33%> (-0.56%) ⬇️
components/time-picker/time-picker.component.ts 85.93% <33.33%> (-1.27%) ⬇️
components/cascader/cascader.component.ts 94.63% <50.00%> (-0.59%) ⬇️
components/date-picker/picker.component.ts 90.56% <50.00%> (-1.11%) ⬇️
components/tooltip/base.ts 91.95% <66.66%> (-0.47%) ⬇️
components/mention/mention.component.ts 98.18% <75.00%> (-0.62%) ⬇️
...ts/auto-complete/autocomplete-trigger.directive.ts 95.67% <100.00%> (-0.03%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dc1ff3...7493977. Read the comment docs.

@wzhudev
Copy link
Member

wzhudev commented Oct 15, 2020

cdk 终于加了这个功能了,感恩!

Related components:
autocomplete, cascader, datepicker, timepicker, mention, popconfirm, popover, tooltip, select, treeselect

close NG-ZORRO#4763
close NG-ZORRO#5061
close NG-ZORRO#4259
close NG-ZORRO#2508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants