feat(module:transfer): add transfer component #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vthinkxie
reviewed
Nov 17, 2017
| @@ -118,6 +119,7 @@ export { NzBackTopModule } from './back-top/nz-back-top.module'; | |||
| export { NzAffixModule } from './affix/nz-affix.module'; | |||
| export { NzAnchorModule } from './anchor/nz-anchor.module'; | |||
| export { NzAvatarModule } from './avatar/nz-avatar.module'; | |||
| export { NzTransferModule } from './transfer/nz-transfer.module'; | |||
There was a problem hiding this comment.
forget to export TransferComponent?
vthinkxie
reviewed
Nov 17, 2017
| @Component({ | ||
| selector: 'nz-transfer-search', | ||
| template: ` | ||
| <input nz-input type="text" [(ngModel)]="value" (ngModelChange)="_handle()" |
There was a problem hiding this comment.
there is no need to add type="text" as default attribute
vthinkxie
reviewed
Nov 17, 2017
| </tr> | ||
| <tr> | ||
| <td>nzItemUnit</td> | ||
| <td>标题项目单位</td> |
There was a problem hiding this comment.
not clear enough
单数单位 maybe better?
vthinkxie
reviewed
Nov 17, 2017
| </tr> | ||
| <tr> | ||
| <td>nzItemsUnit</td> | ||
| <td>标题项目单位</td> |
There was a problem hiding this comment.
not clear enough
复数单位 maybe better?
vthinkxie
reviewed
Nov 17, 2017
| } | ||
|
|
||
| _handleSelect(item: TransferItem) { | ||
| item.checked = !item.checked; |
There was a problem hiding this comment.
no, originally just rely nz-checkbox, thx.
|
Button icon don't alignment, i do not know how it is caused?
do you have any advice? |
export transfer component. fix code review issues.
|
@cipchk it seems ok on mac computer. |
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
export transfer component. fix code review issues. related NG-ZORRO#132
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information