-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:i18n): update date-fns to 2.x #4240
Conversation
Deploy preview for ng-zorro-master ready! Built with commit 06c8028 |
Codecov Report
@@ Coverage Diff @@
## master #4240 +/- ##
==========================================
+ Coverage 92.2% 92.31% +0.11%
==========================================
Files 520 519 -1
Lines 11039 10963 -76
Branches 1997 1984 -13
==========================================
- Hits 10178 10121 -57
+ Misses 429 419 -10
+ Partials 432 423 -9
Continue to review full report at Codecov.
|
06c8028
to
3176540
Compare
这个 PR 合到了 #4346 |
@wenqi73 这个会带来 break change,最好不要在一个 PR 里做,如果用户传了格式化字符串会挂掉的 |
@wendzhue 会放到 9.0.0 再合。 |
@wenqi73 那这个 PR 我先关了 |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Breaking changes will be introduced by date-fns, see https://github.com/date-fns/date-fns/blob/master/CHANGELOG.md#changed.
Other information