Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tree-select): should not close when the selectable is false #3843

Merged
merged 2 commits into from
Jul 29, 2019

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3833

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Jul 22, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 17d67de

https://deploy-preview-3843--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jul 22, 2019

Codecov Report

Merging #3843 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3843      +/-   ##
==========================================
+ Coverage   95.36%   95.36%   +<.01%     
==========================================
  Files         723      723              
  Lines       14722    14729       +7     
  Branches     1937     1937              
==========================================
+ Hits        14040    14047       +7     
  Misses        249      249              
  Partials      433      433
Impacted Files Coverage Δ
components/tree-select/nz-tree-select.component.ts 99.08% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b27681...17d67de. Read the comment docs.

@hsuanxyz hsuanxyz merged commit 329ec22 into NG-ZORRO:master Jul 29, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
NG-ZORRO#3843)

* fix(module:tree-select): should not close when the selectable is false

close NG-ZORRO#3833

* test(module:tree-select): test getter
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
NG-ZORRO#3843)

* fix(module:tree-select): should not close when the selectable is false

close NG-ZORRO#3833

* test(module:tree-select): test getter
@hsuanxyz hsuanxyz deleted the fix/tree-select-selectable branch August 5, 2020 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants