chore: sync with antd 3.19 #3590

hsuanxyz · 2019-06-17T03:31:37Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe:

What is the current behavior?

Issue Number: #3569

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

netlify · 2019-06-17T03:39:51Z

Deploy preview for ng-zorro-master ready!

Built with commit b22c395

https://deploy-preview-3590--ng-zorro-master.netlify.com

codecov · 2019-06-17T06:42:00Z

Codecov Report

Merging #3590 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3590      +/-   ##
==========================================
+ Coverage   95.72%   95.73%   +<.01%     
==========================================
  Files         690      690              
  Lines       13708    13708              
  Branches     1824     1824              
==========================================
+ Hits        13122    13123       +1     
  Misses        198      198              
+ Partials      388      387       -1

Impacted Files	Coverage Δ
components/page-header/nz-page-header.component.ts	`100% <ø> (ø)`	⬆️
components/time-picker/time-holder.ts	`97.26% <0%> (+0.68%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7b5d35...b22c395. Read the comment docs.

vthinkxie

LGTM

* chore: sync ant-design v3.19.6 (NG-ZORRO#3602) * fix(module:table): fix sortChange with dynamic columns (NG-ZORRO#3603) (NG-ZORRO#3605) close NG-ZORRO#3603 * chore: sync with antd 3.19 (NG-ZORRO#3590) * chore: sync with antd 3.19 * test(module:page-header): fix test * chore: refactor commit hook (NG-ZORRO#3610) * chore: refactor commit hook * chore(packaging): clean dependencie * chore(packaging): clean dev dependencie * chore: refactor commit hook (NG-ZORRO#3610) * chore: refactor commit hook * chore(packaging): clean dependencie * chore(packaging): clean dev dependencie * chore: refactor commit hook (NG-ZORRO#3610) * chore: refactor commit hook * chore(packaging): clean dependencie * chore(packaging): clean dev dependencie * build: refactor scripts ref NG-ZORRO#2474 * chore: update ci config * ci: fix integration * ci: add travis_wait * ci: fix ci * ci: fix ci * ci: fix ci * ci: fix ci * ci: fix ci * chore: fix type * build: add site release scripts * build: _ * build: add `test:watch` task * build: fix `test:watch` task * chore: bump node to 12.1.0 * ci: add now.json

* chore: sync ant-design v3.19.6 (NG-ZORRO#3602) * fix(module:table): fix sortChange with dynamic columns (NG-ZORRO#3603) (NG-ZORRO#3605) close NG-ZORRO#3603 * chore: sync with antd 3.19 (NG-ZORRO#3590) * chore: sync with antd 3.19 * test(module:page-header): fix test * chore: refactor commit hook (NG-ZORRO#3610) * chore: refactor commit hook * chore(packaging): clean dependencie * chore(packaging): clean dev dependencie * chore: refactor commit hook (NG-ZORRO#3610) * chore: refactor commit hook * chore(packaging): clean dependencie * chore(packaging): clean dev dependencie * chore: refactor commit hook (NG-ZORRO#3610) * chore: refactor commit hook * chore(packaging): clean dependencie * chore(packaging): clean dev dependencie * build: refactor scripts ref NG-ZORRO#2474 * chore: update ci config * ci: fix integration * ci: add travis_wait * ci: fix ci * ci: fix ci * ci: fix ci * ci: fix ci * ci: fix ci * chore: fix type * build: add site release scripts * build: _ * build: add `test:watch` task * build: fix `test:watch` task * chore: bump node to 12.1.0 * ci: add now.json * ci: add now.json

* chore: sync with antd 3.19 * test(module:page-header): fix test

chore: sync with antd 3.19

fa55df5

test(module:page-header): fix test

b22c395

vthinkxie approved these changes Jun 19, 2019

View reviewed changes

vthinkxie merged commit 9522658 into NG-ZORRO:master Jun 19, 2019

weekly-digest bot mentioned this pull request Jun 23, 2019

Weekly Digest (16 June, 2019 - 23 June, 2019) #3630

Closed

Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020

chore: sync with antd 3.19 (NG-ZORRO#3590)

fd499c7

* chore: sync with antd 3.19 * test(module:page-header): fix test

hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020

chore: sync with antd 3.19 (NG-ZORRO#3590)

a6a8eaa

* chore: sync with antd 3.19 * test(module:page-header): fix test

hsuanxyz deleted the chore/antd-3.19 branch August 5, 2020 02:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: sync with antd 3.19 #3590

chore: sync with antd 3.19 #3590

hsuanxyz commented Jun 17, 2019

netlify bot commented Jun 17, 2019 •

edited

Loading

codecov bot commented Jun 17, 2019 •

edited

Loading

vthinkxie left a comment

chore: sync with antd 3.19 #3590

chore: sync with antd 3.19 #3590

Conversation

hsuanxyz commented Jun 17, 2019

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

netlify bot commented Jun 17, 2019 • edited Loading

codecov bot commented Jun 17, 2019 • edited Loading

Codecov Report

vthinkxie left a comment

Choose a reason for hiding this comment

netlify bot commented Jun 17, 2019 •

edited

Loading

codecov bot commented Jun 17, 2019 •

edited

Loading