-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:menu): submenu should not remain highlighted #3455
Conversation
Deploy preview for ng-zorro-master ready! Built with commit dffbf42 |
Codecov Report
@@ Coverage Diff @@
## master #3455 +/- ##
=========================================
- Coverage 96.66% 95.5% -1.16%
=========================================
Files 609 609
Lines 13187 13216 +29
Branches 1803 1804 +1
=========================================
- Hits 12747 12622 -125
- Misses 199 212 +13
- Partials 241 382 +141
Continue to review full report at Codecov.
|
@@ -200,6 +200,9 @@ export class NzSubMenuComponent implements OnInit, OnDestroy, AfterContentInit, | |||
takeUntil(this.destroy$) | |||
) | |||
.subscribe(selected => { | |||
if (selected === false) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- if (selected === false) {
- this.isMouseHover = selected;
- }
应该在 this.nzSubmenuService.open$
改变的时候设置 isMouseHover
的状态.
* fix(module:menu): submenu should not remain highlighted * fix: add unit test * fix: set isMouseHover when overlay collapse
* fix(module:menu): submenu should not remain highlighted * fix: add unit test * fix: set isMouseHover when overlay collapse
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #3434
What is the new behavior?
Does this PR introduce a breaking change?
Other information