Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:table): fix selector error #1742

Merged
merged 3 commits into from
Jun 28, 2018

Conversation

tirelyl
Copy link
Contributor

@tirelyl tirelyl commented Jun 27, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

"td" and "th" selector will conflict with user custom component and throw Template parse error: "More than one component matched on this element..."
Issue Number: #1736

What is the new behavior?

"td" and "th" selector will not conflict with user custom component by use “not:(.custom-tag)” in selector

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pr!
The class should be more specific like nz-disable-th
and please add test file.

@codecov
Copy link

codecov bot commented Jun 28, 2018

Codecov Report

Merging #1742 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1742      +/-   ##
==========================================
+ Coverage   96.06%   96.06%   +<.01%     
==========================================
  Files         466      466              
  Lines       11143    11145       +2     
  Branches     1455     1456       +1     
==========================================
+ Hits        10704    10706       +2     
  Misses        127      127              
  Partials      312      312
Impacted Files Coverage Δ
components/table/nz-td.component.ts 100% <ø> (ø) ⬆️
components/table/nz-th.component.ts 100% <ø> (ø) ⬆️
components/radio/nz-radio-group.component.ts 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a516949...38cf075. Read the comment docs.

@vthinkxie vthinkxie merged commit aeb485f into NG-ZORRO:master Jun 28, 2018
wenqi73 pushed a commit to wenqi73/ng-zorro-antd that referenced this pull request Aug 27, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants