Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:(module:tree-select): add tree-select component #1477

Merged
merged 1 commit into from
May 31, 2018

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1391

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented May 26, 2018

Codecov Report

Merging #1477 into master will increase coverage by 0.08%.
The diff coverage is 98.67%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1477      +/-   ##
=========================================
+ Coverage   96.92%     97%   +0.08%     
=========================================
  Files         222     224       +2     
  Lines        9514    9735     +221     
  Branches     1299    1335      +36     
=========================================
+ Hits         9221    9443     +222     
+ Misses         43      42       -1     
  Partials      250     250
Impacted Files Coverage Δ
components/tree-select/nz-tree-select.module.ts 100% <100%> (ø)
components/tree/nz-tree-node.ts 93.75% <100%> (+0.27%) ⬆️
components/tree/nz-tree.service.ts 95.74% <100%> (+2.12%) ⬆️
components/tree/nz-tree-node.component.ts 94.21% <100%> (+0.03%) ⬆️
components/tree/nz-tree.component.ts 100% <100%> (ø) ⬆️
components/tree-select/nz-tree-select.component.ts 98.54% <98.54%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a6b03d...2fea020. Read the comment docs.

@hsuanxyz hsuanxyz changed the title WIP:(module:tree-select): add tree-select component feat:(module:tree-select): add tree-select component May 26, 2018
@hsuanxyz
Copy link
Member Author

@vthinkxie Request review.

return this.nzCheckable ? (!event.node.isDisabled && !event.node.isDisableCheckbox) : !event.node.isDisabled;
})
),
this.nzCheckable ? this.nzTreeCheckBoxChange : observableOf(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nzTreeCheckBoxChange not work

@vthinkxie vthinkxie merged commit 7c6fd1e into NG-ZORRO:master May 31, 2018
@hsuanxyz hsuanxyz deleted the tree-select/add branch July 1, 2018 07:01
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants