Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:watermark): cleanup event listeners once settled #8862

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Nov 7, 2024

No description provided.

Copy link

zorro-bot bot commented Nov 7, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.87%. Comparing base (472bb34) to head (fc78f50).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
components/water-mark/water-mark.component.ts 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8862      +/-   ##
==========================================
- Coverage   91.88%   91.87%   -0.01%     
==========================================
  Files         537      537              
  Lines       18453    18460       +7     
  Branches     2814     2814              
==========================================
+ Hits        16955    16961       +6     
- Misses       1196     1197       +1     
  Partials      302      302              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. WDYT? @OriginRing

@Laffery Laffery changed the title fix(module:water-mark): cleanup event listeners once settled fix(module:watermark): cleanup event listeners once settled Nov 12, 2024
@Laffery
Copy link
Collaborator

Laffery commented Nov 12, 2024

@arturovt Please fix the CI errors, which might be caused by a previous commit had been fixed, try to rebase

@OriginRing
Copy link
Collaborator

LGTM

@Laffery Laffery merged commit decd477 into NG-ZORRO:master Nov 12, 2024
8 of 10 checks passed
@arturovt arturovt deleted the fix/wm-cleanup branch November 12, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants