-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:watermark): cleanup event listeners once settled #8862
Conversation
This preview will be available after the AzureCI is passed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8862 +/- ##
==========================================
- Coverage 91.88% 91.87% -0.01%
==========================================
Files 537 537
Lines 18453 18460 +7
Branches 2814 2814
==========================================
+ Hits 16955 16961 +6
- Misses 1196 1197 +1
Partials 302 302 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. WDYT? @OriginRing
@arturovt Please fix the CI errors, which might be caused by a previous commit had been fixed, try to rebase |
LGTM |
cbeabb5
to
fc78f50
Compare
No description provided.