Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:badge): NG0955 warning in nz-badge-sup component #8858

Merged

Conversation

Nicoss54
Copy link
Collaborator

@Nicoss54 Nicoss54 commented Nov 7, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

NG0095 warning

Issue Number: N/A

What is the new behavior?

NG0095 warning disappears

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

zorro-bot bot commented Nov 7, 2024

This preview will be available after the AzureCI is passed.

@Nicoss54 Nicoss54 force-pushed the fix/nz-badge-ng0095-track-expression branch from fd8f651 to 0b0ebb9 Compare November 7, 2024 13:34
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.95%. Comparing base (d28876c) to head (0b0ebb9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8858   +/-   ##
=======================================
  Coverage   91.95%   91.95%           
=======================================
  Files         537      537           
  Lines       18452    18453    +1     
  Branches     2814     2814           
=======================================
+ Hits        16967    16968    +1     
  Misses       1183     1183           
  Partials      302      302           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery changed the title fix(module:badge): ng0095 warning fix(module:badge): NG0955 warning in nz-budge-sup component Nov 7, 2024
@Laffery Laffery changed the title fix(module:badge): NG0955 warning in nz-budge-sup component fix(module:badge): NG0955 warning in nz-badge-sup component Nov 7, 2024
@Laffery Laffery merged commit cc52555 into NG-ZORRO:master Nov 7, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants