Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(packaging): bump compiler-cli to 18.1.2 to fix ngtypecheck issue #8699

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

Laffery
Copy link
Collaborator

@Laffery Laffery commented Aug 19, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: close #8697

https://www.npmjs.com/package/ng-zorro-antd/v/18.1.0?activeTab=code

image

What is the new behavior?

no references emit any more.

image

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

We should publish a patch version 18.1.1 for this fix

Copy link

zorro-bot bot commented Aug 19, 2024

This preview will be available after the AzureCI is passed.

@Laffery Laffery added PR: unreviewed dependencies Pull requests that update a dependency file labels Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.54%. Comparing base (75a4e92) to head (6c97138).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8699   +/-   ##
=======================================
  Coverage   91.53%   91.54%           
=======================================
  Files         536      538    +2     
  Lines       18438    18441    +3     
  Branches     2816     2816           
=======================================
+ Hits        16877    16881    +4     
+ Misses       1242     1241    -1     
  Partials      319      319           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@HyperLife1119 HyperLife1119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyperLife1119 HyperLife1119 merged commit 8e459c1 into NG-ZORRO:master Aug 19, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file PR: target-patch PR: unreviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular 18.1 ngtypecheck issue.
2 participants