Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:transfer): disabling selection does not affect selecting all #8633

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

OriginRing
Copy link
Collaborator

@OriginRing OriginRing commented Jul 12, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

[REPRODUTION STEPS]

  • take the basic usage demo for example
  • select all items in left and transfer to right
  • then all the items in left are disabled, but the SELECT-ALL button in left still works

transfer

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@OriginRing OriginRing requested a review from Ricbet as a code owner July 12, 2024 08:45
Copy link

zorro-bot bot commented Jul 12, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.51%. Comparing base (9dd14ae) to head (0e53714).
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8633   +/-   ##
=======================================
  Coverage   91.50%   91.51%           
=======================================
  Files         534      534           
  Lines       18425    18427    +2     
  Branches     2905     2906    +1     
=======================================
+ Hits        16860    16863    +3     
  Misses       1244     1244           
+ Partials      321      320    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery merged commit 75d8c7b into NG-ZORRO:master Jul 24, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants