Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:table): fix @for track function #8593

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

huajian123
Copy link
Contributor

@huajian123 huajian123 commented Jun 23, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

Copy link

zorro-bot bot commented Jun 23, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.50%. Comparing base (6bb95c0) to head (bc9204a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8593   +/-   ##
=======================================
  Coverage   91.50%   91.50%           
=======================================
  Files         534      534           
  Lines       18425    18425           
  Branches     2905     2905           
=======================================
  Hits        16860    16860           
  Misses       1244     1244           
  Partials      321      321           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@HyperLife1119 HyperLife1119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Because these elements may be repeated, they cannot be used as track keys.

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery merged commit b275063 into NG-ZORRO:master Jun 24, 2024
9 checks passed
@HyperLife1119 HyperLife1119 mentioned this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants