Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:table): missing no-result in fixed header table #8574

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

vmural
Copy link
Contributor

@vmural vmural commented Jun 8, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@vmural vmural requested a review from vthinkxie as a code owner June 8, 2024 09:10
Copy link

zorro-bot bot commented Jun 8, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Jun 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.49%. Comparing base (843b703) to head (5016211).
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8574      +/-   ##
==========================================
- Coverage   91.57%   91.49%   -0.08%     
==========================================
  Files         532      534       +2     
  Lines       18338    18425      +87     
  Branches     2803     2815      +12     
==========================================
+ Hits        16793    16858      +65     
- Misses       1228     1246      +18     
- Partials      317      321       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@HyperLife1119 HyperLife1119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will solve #8599

@Laffery Laffery merged commit 6cff80e into NG-ZORRO:master Jun 27, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants