Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:rate): rate half value when allow half is false #8536

Conversation

imaliouris
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #8535

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Copy link

zorro-bot bot commented May 9, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.58%. Comparing base (81ef077) to head (2b72f4e).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8536   +/-   ##
=======================================
  Coverage   91.57%   91.58%           
=======================================
  Files         533      533           
  Lines       18336    18336           
  Branches     2801     2802    +1     
=======================================
+ Hits        16792    16793    +1     
  Misses       1226     1226           
+ Partials      318      317    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Laffery Laffery changed the title fix: rate half value when allow half is false fix(module:rate): rate half value when allow half is false May 24, 2024
Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery added this to the v18 Support milestone May 24, 2024
@Laffery Laffery merged commit 7742fe3 into NG-ZORRO:master May 28, 2024
9 checks passed
@imaliouris imaliouris deleted the fix/rate-half-value-when-allow-half-is-false branch May 28, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants