Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:color-picker): avoid emitted twice nzOnChange event #8530

Merged
merged 1 commit into from
May 20, 2024

Conversation

Nicoss54
Copy link
Collaborator

@Nicoss54 Nicoss54 commented May 2, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

When we change the color of color-picket nzOnChange event is emitted twice

Issue Number: #8502

What is the new behavior?

When we change the color of color picker nzOnChange event is emitted only one time

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

Copy link

zorro-bot bot commented May 2, 2024

This preview will be available after the AzureCI is passed.

@Nicoss54 Nicoss54 linked an issue May 2, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.58%. Comparing base (81ef077) to head (08295d2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8530   +/-   ##
=======================================
  Coverage   91.57%   91.58%           
=======================================
  Files         533      533           
  Lines       18336    18338    +2     
  Branches     2801     2801           
=======================================
+ Hits        16792    16794    +2     
  Misses       1226     1226           
  Partials      318      318           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OriginRing
Copy link
Collaborator

LGTM

Copy link
Collaborator

@HyperLife1119 HyperLife1119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OriginRing OriginRing merged commit 5dea059 into NG-ZORRO:master May 20, 2024
9 checks passed
@Nicoss54 Nicoss54 deleted the fix/nzOnChange-emitted-twice branch July 31, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The nzOnChange event of the ColorPicker component will run twice
3 participants