Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:list): static query list-item-action template #8527

Merged
merged 1 commit into from
May 20, 2024

Conversation

HyperLife1119
Copy link
Collaborator

@HyperLife1119 HyperLife1119 commented Apr 29, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #8517

image

What is the new behavior?

Since the ng-template within an action component is static, we can turn on the static option to get to them faster.

image

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@HyperLife1119 HyperLife1119 linked an issue Apr 29, 2024 that may be closed by this pull request
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.57%. Comparing base (81ef077) to head (cd0962f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8527      +/-   ##
==========================================
- Coverage   91.57%   91.57%   -0.01%     
==========================================
  Files         533      533              
  Lines       18336    18336              
  Branches     2801     2801              
==========================================
- Hits        16792    16791       -1     
- Misses       1226     1227       +1     
  Partials      318      318              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OriginRing OriginRing merged commit 85301e0 into NG-ZORRO:master May 20, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<nz-list-item-action> not visible
3 participants