Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:tag): borderless mode #8320

Merged
merged 5 commits into from
Jan 17, 2024

Conversation

ParsaArvanehPA
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[✔] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Ant design provides a borderless mode for its tag component, which is not available in ng-zorro.

What is the new behavior?

Implemented borderless mode for tag component.

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

Copy link

zorro-bot bot commented Dec 23, 2023

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Dec 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8c0dd00) 91.72% compared to head (b3e401b) 91.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8320      +/-   ##
==========================================
+ Coverage   91.72%   91.73%   +0.01%     
==========================================
  Files         520      520              
  Lines       18010    18011       +1     
  Branches     2838     2838              
==========================================
+ Hits        16519    16522       +3     
+ Misses       1188     1186       -2     
  Partials      303      303              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Nicoss54 Nicoss54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make pass the linter

@ParsaArvanehPA
Copy link
Contributor Author

make pass the linter

Thank you for checking my pr.
Linter problems are now fixed.

@OriginRing OriginRing merged commit e428083 into NG-ZORRO:master Jan 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants