-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:image): zoom using mouse wheel #8180
feat(module:image): zoom using mouse wheel #8180
Conversation
…w-can-zoom-with-mouse-wheel # Conflicts: # components/image/image-preview.component.ts
…ouse-wheel # Conflicts: # components/image/image-preview.component.ts
This preview will be available after the AzureCI is passed. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #8180 +/- ##
==========================================
- Coverage 91.75% 91.62% -0.14%
==========================================
Files 519 519
Lines 18041 18076 +35
Branches 2842 2848 +6
==========================================
+ Hits 16554 16562 +8
- Misses 1184 1216 +32
+ Partials 303 298 -5 ☔ View full report in Codecov by Sentry. |
…ouse-wheel # Conflicts: # components/image/image-preview.component.ts
@HyperLife1119 @Nicoss54 I would be grateful if you could review my pull request. |
@HyperLife1119 i am going to tackle this if you’re ok ? |
Give it to you :) |
LGTM |
…ouse-wheel # Conflicts: # components/image/image-preview.component.ts
…ouse-wheel # Conflicts: # components/image/image-preview.component.ts
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The image component in antd supports zooming in the image with the mouse wheel, but this feature is not available in our image component.
Issue Number: N/A
What is the new behavior?
The image can be zoomed in with the mouse wheel, and the zooming center is aligned with the mouse cursor position.
Does this PR introduce a breaking change?
Other information