Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:image): zoom using mouse wheel #8180

Conversation

ParsaArvanehPA
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[✔] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The image component in antd supports zooming in the image with the mouse wheel, but this feature is not available in our image component.

Issue Number: N/A

What is the new behavior?

The image can be zoomed in with the mouse wheel, and the zooming center is aligned with the mouse cursor position.

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

Copy link

zorro-bot bot commented Nov 21, 2023

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (e856515) 91.75% compared to head (ac27383) 91.62%.

Files Patch % Lines
components/image/image-preview.component.ts 67.44% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8180      +/-   ##
==========================================
- Coverage   91.75%   91.62%   -0.14%     
==========================================
  Files         519      519              
  Lines       18041    18076      +35     
  Branches     2842     2848       +6     
==========================================
+ Hits        16554    16562       +8     
- Misses       1184     1216      +32     
+ Partials      303      298       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ParsaArvanehPA
Copy link
Contributor Author

@HyperLife1119 @Nicoss54 I would be grateful if you could review my pull request.

@Nicoss54
Copy link
Collaborator

Nicoss54 commented Dec 7, 2023

@HyperLife1119 @Nicoss54 I would be grateful if you could review my pull request.

@HyperLife1119 i am going to tackle this if you’re ok ?

@HyperLife1119
Copy link
Collaborator

@HyperLife1119 @Nicoss54 I would be grateful if you could review my pull request.

@HyperLife1119 i am going to tackle this if you’re ok ?

Give it to you :)

@Nicoss54
Copy link
Collaborator

Nicoss54 commented Dec 7, 2023

LGTM

@HyperLife1119 HyperLife1119 merged commit 4235c29 into NG-ZORRO:master Feb 19, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants