Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:calendar): fix month/year view switched #768

Merged
merged 1 commit into from
Dec 30, 2017
Merged

fix(module:calendar): fix month/year view switched #768

merged 1 commit into from
Dec 30, 2017

Conversation

chunghha
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

ng-zorro-antd calendar month/year mode view is switched wrongly as I reported the problem in 767.
Issue Number: #767

What is the new behavior?

fixes the month/year mode view

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

Coverage Status

Coverage remained the same at 40.765% when pulling 937610e on chunghha:calendar into 196a12a on NG-ZORRO:master.

@wilsoncook wilsoncook merged commit 383a0f4 into NG-ZORRO:master Dec 30, 2017
wilsoncook added a commit that referenced this pull request Jan 2, 2018
wilsoncook added a commit that referenced this pull request Jan 2, 2018
* Revert "release(0.6.9): release 0.6.9 (#841)"

This reverts commit f514cf3.

* Revert "fix(module:transfer): 1.fix the "checkAll" status not updated 2.change "ArrayObservable.of" to "of" (#834)"

This reverts commit 9c023fa.

* Revert "docs(showcase): optimization docs (#733)"

This reverts commit 29318db.

* Revert "fix(module:calendar): fix month/year view switched (#768)"

This reverts commit 383a0f4.
@wilsoncook
Copy link
Member

Hi, @chunghha , this PR causes some bugs to datepicker etc. that associate with calendar, please check more to complete this bugfix:
image

Thank you for your efforts.

@chunghha
Copy link
Contributor Author

chunghha commented Jan 2, 2018

@wilsoncook I am sorry for that you got to revert this PR. I see the datepicker component is tied to the calendar component. I will be working on this PR again after #656 will get merged.

hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…#843)

* Revert "release(0.6.9): release 0.6.9 (NG-ZORRO#841)"

This reverts commit f514cf3.

* Revert "fix(module:transfer): 1.fix the "checkAll" status not updated 2.change "ArrayObservable.of" to "of" (NG-ZORRO#834)"

This reverts commit 9c023fa.

* Revert "docs(showcase): optimization docs (NG-ZORRO#733)"

This reverts commit 29318db.

* Revert "fix(module:calendar): fix month/year view switched (NG-ZORRO#768)"

This reverts commit 383a0f4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants