Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:input-number): add nzReadOnly property #7372

Merged
merged 8 commits into from
Apr 20, 2022

Conversation

chenc041
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7369

Closes: #7369

What is the new behavior?

Add new property of nzReadOnly

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Apr 19, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #7372 (12c7185) into master (64e1c7c) will decrease coverage by 0.03%.
The diff coverage is 75.00%.

❗ Current head 12c7185 differs from pull request most recent head 9d713bd. Consider uploading reports for the commit 9d713bd to get more accurate results

@@            Coverage Diff             @@
##           master    #7372      +/-   ##
==========================================
- Coverage   91.62%   91.58%   -0.04%     
==========================================
  Files         487      487              
  Lines       16013    16016       +3     
  Branches     2604     2605       +1     
==========================================
- Hits        14672    14669       -3     
- Misses       1027     1035       +8     
+ Partials      314      312       -2     
Impacted Files Coverage Δ
components/core/config/config.ts 100.00% <ø> (ø)
components/code-editor/code-editor.service.ts 19.75% <66.66%> (+0.76%) ⬆️
components/input-number/input-number.component.ts 98.64% <100.00%> (+<0.01%) ⬆️
components/table/src/table/tbody.component.ts 88.88% <0.00%> (-11.12%) ⬇️
...ts/table/src/table/table-inner-scroll.component.ts 79.41% <0.00%> (-4.42%) ⬇️
components/table/src/table/tr-measure.component.ts 86.95% <0.00%> (-4.35%) ⬇️
components/table/src/table-style.service.ts 96.55% <0.00%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64e1c7c...9d713bd. Read the comment docs.

| `[nzFormatter]` | Specifies the format of the value presented | `(value: number \| string) => string \| number` | - |
| `[nzParser]` | Specifies the value extracted from nzFormatter | `(value: string) => string \| number` | `(value: string) => value.trim().replace(/。/g, '.').replace(/[^\w\.-]+/g, '')` |
| `[nzPrecision]` | precision of input value | `number` | - |
| property | description | type | default |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary whitespace, please check your config of prettier :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 0da7496 into NG-ZORRO:master Apr 20, 2022
@chenc041 chenc041 deleted the fix-issue-7369 branch June 7, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nz-input-number
2 participants