Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:popconfirm): reverting missing nzPopconfirmVisibleChange #7338

Merged

Conversation

volvachev
Copy link
Contributor

@volvachev volvachev commented Mar 26, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Event nzPopconfirmVisibleChange missing from the component.

Issue Number: #7337

What is the new behavior?

Returns the deleted output event(nzPopconfirmVisibleChange) from the component.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@codecov
Copy link

codecov bot commented Mar 26, 2022

Codecov Report

Merging #7338 (df0694c) into master (b517bd4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head df0694c differs from pull request most recent head 0a55697. Consider uploading reports for the commit 0a55697 to get more accurate results

@@           Coverage Diff           @@
##           master    #7338   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files         487      487           
  Lines       16013    16014    +1     
  Branches     2604     2604           
=======================================
+ Hits        14672    14673    +1     
  Misses       1027     1027           
  Partials      314      314           
Impacted Files Coverage Δ
components/popconfirm/popconfirm.ts 98.70% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b517bd4...0a55697. Read the comment docs.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants