-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:button): prevent default event fire #7267
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #7267 +/- ##
==========================================
+ Coverage 91.68% 91.75% +0.06%
==========================================
Files 486 486
Lines 15920 15950 +30
Branches 2588 2591 +3
==========================================
+ Hits 14597 14635 +38
+ Misses 1011 1003 -8
Partials 312 312
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #7264
What is the new behavior?
When the button state is loading or disabled, the default event will not fire
Does this PR introduce a breaking change?
Other information