Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:slider): fix keydown not trigger nzOnAfterChange #7252

Merged
merged 5 commits into from
Feb 15, 2022

Conversation

chenc041
Copy link
Contributor

@chenc041 chenc041 commented Feb 9, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The key down event won't trigger the nzOnAfterChange callback

Issue Number: #7251

What is the new behavior?

The key down event will trigger the nzOnAfterChange callback

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #7252 (40fb3c9) into master (f40aad9) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 40fb3c9 differs from pull request most recent head afdb439. Consider uploading reports for the commit afdb439 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7252      +/-   ##
==========================================
- Coverage   91.72%   91.68%   -0.04%     
==========================================
  Files         486      486              
  Lines       15918    15919       +1     
  Branches     2588     2588              
==========================================
- Hits        14601    14596       -5     
- Misses       1004     1011       +7     
+ Partials      313      312       -1     
Impacted Files Coverage Δ
components/slider/slider.component.ts 92.27% <100.00%> (+0.02%) ⬆️
components/table/src/table/tr-measure.component.ts 86.36% <0.00%> (-13.64%) ⬇️
components/table/src/table/tbody.component.ts 88.88% <0.00%> (-11.12%) ⬇️
...ts/table/src/table/table-inner-scroll.component.ts 79.41% <0.00%> (-4.42%) ⬇️
components/core/util/text-measure.ts 92.98% <0.00%> (+0.87%) ⬆️
components/table/src/table-style.service.ts 96.55% <0.00%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f40aad9...afdb439. Read the comment docs.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenc041
Copy link
Contributor Author

Cool

@simplejason simplejason merged commit f419c07 into NG-ZORRO:master Feb 15, 2022
@chenc041 chenc041 deleted the fix-issue-7251 branch February 15, 2022 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants