-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:slider): fix keydown not trigger nzOnAfterChange #7252
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7252 +/- ##
==========================================
- Coverage 91.72% 91.68% -0.04%
==========================================
Files 486 486
Lines 15918 15919 +1
Branches 2588 2588
==========================================
- Hits 14601 14596 -5
- Misses 1004 1011 +7
+ Partials 313 312 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cool |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The key down event won't trigger the nzOnAfterChange callback
Issue Number: #7251
What is the new behavior?
The key down event will trigger the nzOnAfterChange callback
Does this PR introduce a breaking change?
Other information