fix(module:icon): do not try to load SVG on the Node.js side since it will throw an error #7242
Conversation
|
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #7242 +/- ##
==========================================
- Coverage 91.72% 91.70% -0.02%
==========================================
Files 486 486
Lines 15918 15921 +3
Branches 2588 2588
==========================================
Hits 14601 14601
- Misses 1004 1007 +3
Partials 313 313
Continue to review full report at Codecov.
|
… will throw an error
components/icon/icon.directive.ts
Outdated
| // this SVG, so we'll have an unnecessary HTTP request on the server-side. There's no sense to | ||
| // call `_changeIcon()` when running the code on the Node.js side. | ||
| if (!this.platform.isBrowser) { | ||
| return; |
There was a problem hiding this comment.
Should support changing icon when using static loading. I would provide an API in @ant-design/icons-angular to turn dynamic loading off.
There was a problem hiding this comment.
Alright, I'll make the changes after that.
|
@arturovt I made some changes. Not sure if we should change |
|
Alright, I'm ok with changes, seems like I have to revert tests. |
|
This seems to still be an issue in 13.1.0? |
PR Checklist
PR Type
What is the current behavior?
Issue Number: #7240