Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:code-editor): always initialize outside of the Angular zone #7151

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

arturovt
Copy link
Member

PR Checklist

PR Type

[x] Bugfix

@codecov
Copy link

codecov bot commented Dec 24, 2021

Codecov Report

Merging #7151 (391983e) into master (c177558) will decrease coverage by 0.03%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7151      +/-   ##
==========================================
- Coverage   91.67%   91.63%   -0.04%     
==========================================
  Files         486      486              
  Lines       15868    15872       +4     
  Branches     2587     2588       +1     
==========================================
- Hits        14547    14545       -2     
- Misses       1007     1012       +5     
- Partials      314      315       +1     
Impacted Files Coverage Δ
components/code-editor/code-editor.component.ts 16.00% <14.28%> (+0.29%) ⬆️
components/core/util/text-measure.ts 92.10% <0.00%> (-0.88%) ⬇️
components/tabs/tab-nav-bar.component.ts 87.23% <0.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c177558...391983e. Read the comment docs.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@simplejason simplejason merged commit f73be80 into NG-ZORRO:master Jan 13, 2022
@arturovt arturovt deleted the fix/editor-zone branch January 13, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants