Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(module:time-picker): do not run change detection when the timer fires #7143

Merged
merged 1 commit into from
Feb 22, 2022
Merged

perf(module:time-picker): do not run change detection when the timer fires #7143

merged 1 commit into from
Feb 22, 2022

Conversation

arturovt
Copy link
Member

PR Checklist

PR Type

[x] Refactoring (no functional changes, no api changes)

@zorro-bot
Copy link

zorro-bot bot commented Dec 23, 2021

This preview will be available after the AzureCI is passed.

simplejason
simplejason approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 72da774 into NG-ZORRO:master Feb 22, 2022
@arturovt arturovt deleted the perf/time-picker-timer branch February 22, 2022 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simplejason simplejason simplejason approved these changes

@wenqi73 wenqi73 Awaiting requested review from wenqi73 wenqi73 is a code owner

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arturovt @simplejason