Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module:select): do not run change detection on events if the nz-option-item is disabled #7133

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

arturovt
Copy link
Member

PR Checklist

PR Type

[x] Refactoring (no functional changes, no api changes)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@zorro-bot
Copy link

zorro-bot bot commented Dec 21, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #7133 (9d590c4) into master (c177558) will decrease coverage by 1.93%.
The diff coverage is 83.33%.

❗ Current head 9d590c4 differs from pull request most recent head 681f4dc. Consider uploading reports for the commit 681f4dc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7133      +/-   ##
==========================================
- Coverage   91.67%   89.74%   -1.94%     
==========================================
  Files         486      488       +2     
  Lines       15868    15941      +73     
  Branches     2587     2579       -8     
==========================================
- Hits        14547    14306     -241     
+ Misses       1007     1002       -5     
- Partials      314      633     +319     
Impacted Files Coverage Δ
components/select/option-item.component.ts 93.93% <83.33%> (-6.07%) ⬇️
components/core/util/observable.ts 33.33% <0.00%> (-33.34%) ⬇️
components/core/util/getMentions.ts 66.66% <0.00%> (-16.67%) ⬇️
components/core/polyfill/request-animation.ts 33.33% <0.00%> (-14.82%) ⬇️
...nts/cdk/resize-observer/resize-observer.service.ts 73.68% <0.00%> (-13.16%) ⬇️
components/pipes/nz-ellipsis.pipe.ts 62.50% <0.00%> (-12.50%) ⬇️
components/resizable/resize-handles.component.ts 87.50% <0.00%> (-12.50%) ⬇️
components/core/util/scroll-into-view-if-needed.ts 62.50% <0.00%> (-12.50%) ⬇️
components/mention/mention.service.ts 90.00% <0.00%> (-10.00%) ⬇️
...nts/table/src/addon/row-expand-button.directive.ts 90.00% <0.00%> (-10.00%) ⬇️
... and 158 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c177558...681f4dc. Read the comment docs.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit a1bbdab into NG-ZORRO:master Feb 25, 2022
@arturovt arturovt deleted the perf/select-option-item branch February 25, 2022 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants