Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module:time-picker): do not run change detection when the time picker panel is clicked #7126

Merged
merged 1 commit into from
Dec 18, 2021

Conversation

arturovt
Copy link
Member

PR Checklist

PR Type

[x] Refactoring (no functional changes, no api changes)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@zorro-bot
Copy link

zorro-bot bot commented Dec 17, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #7126 (76f46d6) into master (6d9b1ff) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7126      +/-   ##
==========================================
+ Coverage   89.71%   89.73%   +0.02%     
==========================================
  Files         488      488              
  Lines       15933    15935       +2     
  Branches     2579     2579              
==========================================
+ Hits        14295    14300       +5     
+ Misses       1006     1003       -3     
  Partials      632      632              
Impacted Files Coverage Δ
...ponents/time-picker/time-picker-panel.component.ts 90.55% <100.00%> (+0.86%) ⬆️
components/time-picker/time-holder.ts 95.78% <0.00%> (-1.06%) ⬇️
components/core/util/text-measure.ts 91.22% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d9b1ff...76f46d6. Read the comment docs.

Copy link
Member

@wenqi73 wenqi73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 76da3ff into NG-ZORRO:master Dec 18, 2021
@arturovt arturovt deleted the perf/time-picker-panel-click branch December 18, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants