Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:core): remove resize listener when the app is destroyed #7125

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

arturovt
Copy link
Member

PR Checklist

PR Type

[x] Bugfix

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@zorro-bot
Copy link

zorro-bot bot commented Dec 17, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #7125 (eeaa6ee) into master (6d9b1ff) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7125      +/-   ##
==========================================
- Coverage   89.71%   89.71%   -0.01%     
==========================================
  Files         488      488              
  Lines       15933    15937       +4     
  Branches     2579     2579              
==========================================
+ Hits        14295    14298       +3     
- Misses       1006     1007       +1     
  Partials      632      632              
Impacted Files Coverage Δ
components/core/services/breakpoint.ts 94.44% <66.66%> (-5.56%) ⬇️
components/time-picker/time-holder.ts 95.78% <0.00%> (-1.06%) ⬇️
components/core/util/text-measure.ts 91.22% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d9b1ff...eeaa6ee. Read the comment docs.

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 8437111 into NG-ZORRO:master Jan 13, 2022
@arturovt arturovt deleted the fix/breakpoint-resize branch January 13, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants