-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:popconfirm): missing arrow #7086
fix(module:popconfirm): missing arrow #7086
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #7086 +/- ##
==========================================
- Coverage 89.92% 89.60% -0.33%
==========================================
Files 481 488 +7
Lines 15380 15873 +493
Branches 2344 2584 +240
==========================================
+ Hits 13831 14223 +392
- Misses 929 1017 +88
- Partials 620 633 +13
Continue to review full report at Codecov.
|
Hi. Thanks for this PR. Could you please make the CI pass? |
ok, wait ~ |
pass~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix(module:popconfirm): missing arrow * chore: trigger ci * fix: lint error
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Any default nz-popconfirm will not show the 'arrow' even though it is marked as the default action.
Issue Number: #7064
What is the new behavior?
When using nz-popconfirm it used to have the little 'arrow' on the edge of the popconfirm dialog box;
Does this PR introduce a breaking change?
Other information