perf(module:icon): do not run change detection when changing icon

[arturovt]

PR Checklist

• The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

[x] Refactoring (no functional changes, no api changes)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

[zorro-bot]

This preview will be available after the AzureCI is passed.

[codecov]

Codecov Report

Merging #7071 (9e5d6e4) into master (d45f0ab) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7071      +/-   ##
==========================================
- Coverage   89.57%   89.54%   -0.03%     
==========================================
  Files         488      488              
  Lines       15821    15826       +5     
  Branches     2440     2440              
==========================================
+ Hits        14171    14172       +1     
- Misses       1009     1011       +2     
- Partials      641      643       +2     

Impacted Files	Coverage Δ
components/menu/submenu.component.ts	98.93% <ø> (-0.02%)	⬇️
components/icon/icon.directive.ts	95.58% <100.00%> (+0.42%)	⬆️
...ponents/menu/submenu-non-inline-child.component.ts	81.08% <0.00%> (-2.71%)	⬇️
components/tabs/tab-nav-bar.component.ts	81.56% <0.00%> (-1.42%)	⬇️
components/time-picker/time-holder.ts	95.78% <0.00%> (-1.06%)	⬇️
components/core/util/text-measure.ts	91.22% <0.00%> (+1.75%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d45f0ab...9e5d6e4. Read the comment docs.

[wzhudev]

Hi! Some tests seemed failed to pass. Could you please take a look at it?

Many thanks for this PR and your continuous contributions to ng-zorro-antd!

[arturovt]

Hey, I had to update the components/menu/submenu.component.ts and remove markForCheck() there because it was breaking tests.

Basically, the markForCheck() is not needed there. The onPositionChange is used within the template (positionChange)="onPositionChange($event)" and template event handlers already call markForCheck() internally.

Tests were affected by this change because the [nz-icon] directive is used within menu.spec.ts tests. The changeIcon() promise triggered multiple change detections, and the onPositionChange was called numerous times, reverting the position value.

[simplejason]

LGTM