Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module:modal): do not run change detection when focusing element #7070

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

arturovt
Copy link
Member

PR Checklist

PR Type

[x] Refactoring (no functional changes, no api changes)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@zorro-bot
Copy link

zorro-bot bot commented Nov 16, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #7070 (3467d8f) into master (d45f0ab) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7070      +/-   ##
==========================================
- Coverage   89.57%   89.55%   -0.02%     
==========================================
  Files         488      488              
  Lines       15821    15822       +1     
  Branches     2440     2440              
==========================================
- Hits        14171    14169       -2     
- Misses       1009     1010       +1     
- Partials      641      643       +2     
Impacted Files Coverage Δ
...ponents/modal/modal-confirm-container.component.ts 100.00% <100.00%> (ø)
components/modal/modal-container.component.ts 100.00% <100.00%> (ø)
components/modal/modal-container.ts 92.93% <100.00%> (+0.03%) ⬆️
components/time-picker/time-holder.ts 95.78% <0.00%> (-1.06%) ⬇️
components/tabs/tab-nav-bar.component.ts 82.26% <0.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d45f0ab...3467d8f. Read the comment docs.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit ffcb709 into NG-ZORRO:master Nov 29, 2021
@arturovt arturovt deleted the perf/modal-focus branch November 29, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants