Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:auto-complete): do not run change detection on mousedown and mouseenter for nz-auto-option #7048

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

arturovt
Copy link
Member

PR Checklist

PR Type

[x] Bugfix

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@zorro-bot
Copy link

zorro-bot bot commented Nov 10, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #7048 (dd51d16) into master (8ac005d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head dd51d16 differs from pull request most recent head ad3e323. Consider uploading reports for the commit ad3e323 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7048   +/-   ##
=======================================
  Coverage   89.52%   89.52%           
=======================================
  Files         488      488           
  Lines       15792    15802   +10     
  Branches     2435     2435           
=======================================
+ Hits        14138    14147    +9     
  Misses       1015     1015           
- Partials      639      640    +1     
Impacted Files Coverage Δ
...nts/auto-complete/autocomplete-option.component.ts 98.14% <100.00%> (+0.42%) ⬆️
components/time-picker/time-holder.ts 95.78% <0.00%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ac005d...ad3e323. Read the comment docs.

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz merged commit d6ca43e into NG-ZORRO:master Nov 12, 2021
@arturovt arturovt deleted the fix/auto-complete-cdc branch November 12, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants