Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:resizable): reduce change detection cycles #7036

Merged

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Nov 4, 2021

PR Checklist

PR Type

[x] Bugfix

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@zorro-bot
Copy link

zorro-bot bot commented Nov 4, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #7036 (d4eacda) into master (9700e89) will decrease coverage by 0.00%.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7036      +/-   ##
==========================================
- Coverage   89.51%   89.50%   -0.01%     
==========================================
  Files         488      488              
  Lines       15792    15798       +6     
  Branches     2435     2438       +3     
==========================================
+ Hits        14136    14140       +4     
- Misses       1016     1017       +1     
- Partials      640      641       +1     
Impacted Files Coverage Δ
components/resizable/resizable.directive.ts 92.44% <88.23%> (-0.33%) ⬇️
components/resizable/resize-handle.component.ts 100.00% <100.00%> (ø)
components/core/util/text-measure.ts 89.47% <0.00%> (-1.76%) ⬇️
components/time-picker/time-holder.ts 95.78% <0.00%> (-1.06%) ⬇️
components/tabs/tab-nav-bar.component.ts 82.97% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9700e89...d4eacda. Read the comment docs.

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz merged commit 5cad154 into NG-ZORRO:master Nov 12, 2021
@arturovt arturovt deleted the fix/resizable-reduce-change-detections branch November 12, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants