Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:table): show empty state regardless of loading value #6934

Merged
merged 1 commit into from
Sep 5, 2021

Conversation

ogix
Copy link
Contributor

@ogix ogix commented Aug 20, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Currently when the table is initially loaded (with nzLoading="true") then only table header is shown with loading icon on the top and it does not look good. I've checked React behavior and it shows additionally empty icon in the table body.

Issue Number: N/A

What is the new behavior?

The new behavior shows empty state regardless of loading value. So initially when there is no data and nzLoading="true" is set - it will display empty state together with loading icon.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ogix ogix requested a review from vthinkxie as a code owner August 20, 2021 22:09
@zorro-bot
Copy link

zorro-bot bot commented Aug 20, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #6934 (82910a4) into master (d392b2e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 82910a4 differs from pull request most recent head f7f8904. Consider uploading reports for the commit f7f8904 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6934      +/-   ##
==========================================
+ Coverage   89.50%   89.51%   +0.01%     
==========================================
  Files         489      489              
  Lines       15805    15802       -3     
  Branches     2428     2427       -1     
==========================================
- Hits        14146    14145       -1     
+ Misses       1016     1015       -1     
+ Partials      643      642       -1     
Impacted Files Coverage Δ
components/table/src/table/table.component.ts 90.13% <100.00%> (-0.20%) ⬇️
components/core/util/text-measure.ts 91.30% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d392b2e...f7f8904. Read the comment docs.

Copy link
Member

@wenqi73 wenqi73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 013beda into NG-ZORRO:master Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants