fix(module:image): resolve memory leak #6856
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
Currently, event listeners are not removed from the image element when the directive is destroyed, tho they keep capturing
this
and prevent the directive from being GC'd.__ngContext__[2] & 256
islView[FLAGS] & LViewFlags.Destroyed
, which checks if the directive is in destroyed status (it is):The image preview can be closed by clicking on the close button on either container. This means that one of the streams will emit (
containerClick
orcloseClick
). IfcontainerClick
emits, then thecloseClick
will never complete and vice-versa:What is the new behavior?
The
NzImageDirective
is GC'd successfully.Does this PR introduce a breaking change?