Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:code-editor): re-enter the Angular zone only if the value has been changed #6845

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

arturovt
Copy link
Member

PR Checklist

PR Type

[x] Bugfix

What is the current behavior?

Currently, it's running tick() whenever the onDidChangeContent callback is invoked, but there's an if condition which checks if the value has been changed and does nothing if not.

What is the new behavior?

The nz-code-editor will run tick() only if the value has been changed.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@zorro-bot
Copy link

zorro-bot bot commented Jul 12, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #6845 (bd29a21) into master (29d44af) will increase coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head bd29a21 differs from pull request most recent head f3d06c2. Consider uploading reports for the commit f3d06c2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6845      +/-   ##
==========================================
+ Coverage   89.55%   89.56%   +0.01%     
==========================================
  Files         489      489              
  Lines       15796    15796              
  Branches     2427     2427              
==========================================
+ Hits        14146    14148       +2     
+ Misses       1008     1007       -1     
+ Partials      642      641       -1     
Impacted Files Coverage Δ
components/code-editor/code-editor.component.ts 14.65% <0.00%> (ø)
components/tabs/tab-nav-bar.component.ts 83.03% <0.00%> (ø)
components/core/util/text-measure.ts 91.30% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d44af...f3d06c2. Read the comment docs.

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz merged commit 5c09948 into NG-ZORRO:master Jul 12, 2021
@arturovt arturovt deleted the fix/editor-re-enter-zone branch July 12, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants