Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:badge): enable nzNoAnimation support #6717

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

c3Vu
Copy link
Contributor

@c3Vu c3Vu commented May 25, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #6478

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@c3Vu c3Vu requested a review from hsuanxyz as a code owner May 25, 2021 10:02
@zorro-bot
Copy link

zorro-bot bot commented May 25, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #6717 (a7a26e2) into master (eb938d4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6717      +/-   ##
==========================================
+ Coverage   89.90%   89.91%   +0.01%     
==========================================
  Files         480      480              
  Lines       15362    15364       +2     
  Branches     2490     2490              
==========================================
+ Hits        13811    13815       +4     
+ Misses        931      930       -1     
+ Partials      620      619       -1     
Impacted Files Coverage Δ
components/badge/badge.module.ts 100.00% <ø> (ø)
components/badge/badge-sup.component.ts 100.00% <100.00%> (ø)
components/badge/badge.component.ts 97.77% <100.00%> (+0.05%) ⬆️
...nts/core/no-animation/nz-no-animation.directive.ts 88.88% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb938d4...a7a26e2. Read the comment docs.

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz merged commit 36c03e3 into NG-ZORRO:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants