Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:graph): fix edge default style and wrong toggling group nodes #6615

Merged
merged 2 commits into from
Apr 22, 2021

Conversation

simplejason
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Apr 19, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #6615 (df91e6d) into master (3fa6592) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6615   +/-   ##
=======================================
  Coverage   89.91%   89.91%           
=======================================
  Files         481      481           
  Lines       15382    15382           
  Branches     2345     2345           
=======================================
  Hits        13831    13831           
  Misses        934      934           
  Partials      617      617           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fa6592...df91e6d. Read the comment docs.

@simplejason simplejason changed the title feat(module:graph): support edge multiple types with line and curev fix(module:graph): fix edge default style and wrong toggling group nodes Apr 22, 2021
Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz merged commit c434ea9 into NG-ZORRO:master Apr 22, 2021
@simplejason simplejason deleted the fix-graph branch November 23, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants