Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:experimental-image): add experimental image component #6590

Merged
merged 8 commits into from
Jun 11, 2021

Conversation

stygian-desolator
Copy link
Collaborator

@stygian-desolator stygian-desolator commented Apr 10, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #6514

What is the new behavior?

add new experimental component nz-image-view

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Apr 10, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 10, 2021

Codecov Report

Merging #6590 (cf7d45c) into master (1ec3f64) will decrease coverage by 0.20%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6590      +/-   ##
==========================================
- Coverage   89.88%   89.68%   -0.21%     
==========================================
  Files         479      484       +5     
  Lines       15489    15625     +136     
  Branches     2522     2545      +23     
==========================================
+ Hits        13923    14014      +91     
- Misses        943      980      +37     
- Partials      623      631       +8     
Impacted Files Coverage Δ
components/core/config/config.ts 100.00% <ø> (ø)
components/image/image-preview-options.ts 100.00% <ø> (ø)
components/image/image-preview.component.ts 90.13% <ø> (ø)
components/core/services/image-preload.ts 30.55% <30.55%> (ø)
components/experimental/image/image.component.ts 72.97% <72.97%> (ø)
components/image/image.directive.ts 90.41% <88.88%> (+1.01%) ⬆️
components/experimental/image/image-loader.ts 100.00% <100.00%> (ø)
components/experimental/image/image.module.ts 100.00% <100.00%> (ø)
components/experimental/image/utils.ts 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ec3f64...cf7d45c. Read the comment docs.

@stygian-desolator stygian-desolator changed the title feat(module:image-view): add image-view feat(module:image-view): add experimental component 'image-view' Apr 11, 2021
@stygian-desolator stygian-desolator marked this pull request as ready for review April 11, 2021 14:33
@stygian-desolator stygian-desolator changed the title feat(module:image-view): add experimental component 'image-view' feat(module:image): support 'nzAutoSrc' and 'nzPriority' Apr 15, 2021
@hsuanxyz hsuanxyz changed the title feat(module:image): support 'nzAutoSrc' and 'nzPriority' feat(module:experimental-image): add experimental image component Apr 15, 2021
@vthinkxie
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants