Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: table): fix sort and filter when nzFrontPagination is false #6547

Merged
merged 1 commit into from
Apr 3, 2021
Merged

fix(module: table): fix sort and filter when nzFrontPagination is false #6547

merged 1 commit into from
Apr 3, 2021

Conversation

xiejay97
Copy link
Contributor

close #5457

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Mar 23, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #6547 (5f68637) into master (ba80ec3) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 5f68637 differs from pull request most recent head f4cdd3f. Consider uploading reports for the commit f4cdd3f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6547      +/-   ##
==========================================
- Coverage   89.91%   89.85%   -0.06%     
==========================================
  Files         481      481              
  Lines       15374    15374              
  Branches     2343     2343              
==========================================
- Hits        13823    13815       -8     
- Misses        935      940       +5     
- Partials      616      619       +3     
Impacted Files Coverage Δ
components/table/src/table-data.service.ts 84.61% <100.00%> (ø)
components/tabs/tab-nav-bar.component.ts 81.69% <0.00%> (-2.12%) ⬇️
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba80ec3...f4cdd3f. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vthinkxie vthinkxie merged commit 097cb6c into NG-ZORRO:master Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NzSortFn not work when set nzFrontPagination to false on nzTable component
2 participants