Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:drawer): fix cover when nested (#6381) #6534

Closed
wants to merge 1 commit into from
Closed

fix(module:drawer): fix cover when nested (#6381) #6534

wants to merge 1 commit into from

Conversation

xiejay97
Copy link
Contributor

@xiejay97 xiejay97 commented Mar 19, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: close #6381

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #6534 (c277b67) into master (ddc7ded) will increase coverage by 0.03%.
The diff coverage is 91.13%.

❗ Current head c277b67 differs from pull request most recent head 82dd0ed. Consider uploading reports for the commit 82dd0ed to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6534      +/-   ##
==========================================
+ Coverage   89.90%   89.93%   +0.03%     
==========================================
  Files         479      482       +3     
  Lines       15319    15383      +64     
  Branches     2333     2486     +153     
==========================================
+ Hits        13772    13835      +63     
+ Misses        930      929       -1     
- Partials      617      619       +2     
Impacted Files Coverage Δ
components/core/config/config.ts 100.00% <ø> (ø)
components/modal/modal.module.ts 100.00% <ø> (ø)
components/select/select.component.ts 87.09% <50.00%> (-0.49%) ⬇️
components/modal/modal.component.ts 90.32% <62.50%> (-2.62%) ⬇️
components/mention/mention.component.ts 97.72% <75.00%> (+0.01%) ⬆️
components/dropdown/dropdown.directive.ts 88.57% <85.71%> (-0.21%) ⬇️
...ts/auto-complete/autocomplete-trigger.directive.ts 95.83% <100.00%> (+0.15%) ⬆️
components/auto-complete/autocomplete.component.ts 91.58% <100.00%> (+0.24%) ⬆️
components/cascader/cascader.component.ts 94.62% <100.00%> (+0.01%) ⬆️
components/date-picker/date-picker.component.ts 93.46% <100.00%> (+0.04%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddc7ded...82dd0ed. Read the comment docs.

@hsuanxyz
Copy link
Member

hsuanxyz commented Apr 8, 2021

@Xie-jay Thanks for your contribution, the cause of this problem was that the content was attached early, it has been fixed in A. Thanks again!

@xiejay97
Copy link
Contributor Author

xiejay97 commented Apr 8, 2021

@Xie-jay Thanks for your contribution, the cause of this problem was that the content was attached early, it has been fixed in A. Thanks again!

its more logical, get it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drawer抽屉嵌套组件(内含抽屉)多重打开第一层会遮挡最后打开的抽屉弹层
2 participants