Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:grid): nzGutter support string type #6450

Merged
merged 3 commits into from
Feb 26, 2021
Merged

fix(module:grid): nzGutter support string type #6450

merged 3 commits into from
Feb 26, 2021

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Feb 25, 2021

The following code style is better in strictTemplates mode:

<nz-row [nzGutter]="16">

better:

<nz-row nzGutter="16">

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

The following code style is better in `strictTemplates` mode:

```html
<nz-row [nzGutter]="16">
```

better:

```html
<nz-row nzGutter="16">
```
@zorro-bot
Copy link

zorro-bot bot commented Feb 25, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #6450 (cdc8c6f) into master (2200adc) will decrease coverage by 0.04%.
The diff coverage is 91.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6450      +/-   ##
==========================================
- Coverage   89.86%   89.81%   -0.05%     
==========================================
  Files         478      478              
  Lines       15277    15314      +37     
  Branches     2326     2475     +149     
==========================================
+ Hits        13729    13755      +26     
- Misses        930      941      +11     
  Partials      618      618              
Impacted Files Coverage Δ
components/core/config/config.ts 100.00% <ø> (ø)
components/message/message.component.ts 100.00% <ø> (ø)
components/notification/notification.component.ts 100.00% <ø> (ø)
components/table/src/table/thead.component.ts 91.22% <ø> (ø)
...ponents/time-picker/time-picker-panel.component.ts 88.70% <ø> (ø)
components/transfer/transfer.component.ts 91.73% <ø> (ø)
components/table/src/addon/filter.component.ts 60.31% <50.00%> (+1.85%) ⬆️
components/message/base.ts 87.39% <72.72%> (-1.60%) ⬇️
...mponents/date-picker/date-range-popup.component.ts 91.39% <95.23%> (+0.54%) ⬆️
components/date-picker/date-picker.component.ts 93.42% <100.00%> (+0.04%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2200adc...4d3c348. Read the comment docs.

@hsuanxyz hsuanxyz merged commit ec03c7f into NG-ZORRO:master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants