Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:slider): support dynamic update nzMarks from outside #636

Merged
merged 1 commit into from
Nov 29, 2017

Conversation

wilsoncook
Copy link
Member

close #624

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #624

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 41.715% when pulling daa67c1 on wilsoncook:slider-support-update-nzmarks into d2fc97d on NG-ZORRO:master.

@vthinkxie vthinkxie merged commit aea80c4 into NG-ZORRO:master Nov 29, 2017
@wilsoncook wilsoncook deleted the slider-support-update-nzmarks branch November 29, 2017 14:57
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nzMarks should support dynamic updates from outside
3 participants