Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:dropdown): close menu when click again (#6353) #6354

Merged
merged 1 commit into from
Feb 13, 2021
Merged

fix(module:dropdown): close menu when click again (#6353) #6354

merged 1 commit into from
Feb 13, 2021

Conversation

xiejay97
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: resolve #6353

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jan 19, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #6354 (13e8ff0) into master (8233dc4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6354   +/-   ##
=======================================
  Coverage   89.88%   89.88%           
=======================================
  Files         478      478           
  Lines       15270    15275    +5     
  Branches     2326     2326           
=======================================
+ Hits        13725    13730    +5     
  Misses        929      929           
  Partials      616      616           
Impacted Files Coverage Δ
components/dropdown/dropdown.directive.ts 88.77% <100.00%> (ø)
components/modal/utils.ts 100.00% <0.00%> (ø)
components/modal/modal-types.ts 100.00% <0.00%> (ø)
components/upload/upload.component.ts 94.35% <0.00%> (ø)
components/upload/upload-list.component.ts 95.86% <0.00%> (ø)
components/modal/modal-container.component.ts 100.00% <0.00%> (ø)
...ponents/modal/modal-confirm-container.component.ts 100.00% <0.00%> (ø)
components/core/environments/environment.ts
components/core/environments/environment.test.ts 100.00% <0.00%> (ø)
components/date-picker/date-picker.component.ts 93.37% <0.00%> (+0.04%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8233dc4...13e8ff0. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
some ci was failed, could you plz rebase onto master and try again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opened Dropdown is not being closed when click the host element under click trigger mode
2 participants