Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker): start and end month displays unreasonable #6339

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Jan 12, 2021

fix(module:date-picker,timepicker): trackBy function

close #6308
close #6142
close #5992

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jan 12, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #6339 (86f6731) into master (4711194) will decrease coverage by 0.02%.
The diff coverage is 95.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6339      +/-   ##
==========================================
- Coverage   89.92%   89.90%   -0.03%     
==========================================
  Files         478      478              
  Lines       15250    15258       +8     
  Branches     2318     2324       +6     
==========================================
+ Hits        13713    13717       +4     
- Misses        924      926       +2     
- Partials      613      615       +2     
Impacted Files Coverage Δ
...mponents/date-picker/date-range-popup.component.ts 90.85% <ø> (ø)
components/date-picker/lib/date-table.component.ts 97.18% <ø> (ø)
...mponents/date-picker/lib/decade-table.component.ts 94.73% <ø> (ø)
...omponents/date-picker/lib/month-table.component.ts 88.13% <ø> (ø)
components/date-picker/lib/year-table.component.ts 89.55% <ø> (ø)
components/date-picker/picker.component.ts 88.12% <0.00%> (-0.56%) ⬇️
components/core/time/candy-date.ts 84.21% <100.00%> (-0.93%) ⬇️
...omponents/date-picker/calendar-footer.component.ts 96.00% <100.00%> (+0.16%) ⬆️
components/date-picker/date-picker.service.ts 100.00% <100.00%> (ø)
...ponents/time-picker/time-picker-panel.component.ts 88.70% <100.00%> (-0.32%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4711194...86f6731. Read the comment docs.

fix(module:date-picker,timepicker): trackBy function

close NG-ZORRO#6308
close NG-ZORRO#6142
close NG-ZORRO#5992
Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz merged commit 7f47698 into NG-ZORRO:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment