Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:modal): add nzOkDanger to avoid old button style #6157

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

yangjunhan
Copy link
Contributor

close #6111

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #6111

What is the new behavior?

Add nzOkDanger and danger in nzFooter APIs to avoid using old danger button style.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Dec 7, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #6157 (a47244f) into master (47065f6) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6157      +/-   ##
==========================================
+ Coverage   89.81%   89.85%   +0.03%     
==========================================
  Files         468      468              
  Lines       14255    14259       +4     
  Branches     2241     2242       +1     
==========================================
+ Hits        12803    12812       +9     
+ Misses        896      891       -5     
  Partials      556      556              
Impacted Files Coverage Δ
components/modal/modal-footer.component.ts 100.00% <ø> (ø)
components/modal/utils.ts 100.00% <ø> (ø)
components/button/button.component.ts 100.00% <100.00%> (ø)
components/modal/modal-types.ts 100.00% <100.00%> (ø)
components/modal/modal.component.ts 92.85% <100.00%> (+0.08%) ⬆️
components/time-picker/time-holder.ts 94.73% <0.00%> (-1.06%) ⬇️
components/tabs/tab-nav-bar.component.ts 82.33% <0.00%> (+0.70%) ⬆️
components/table/src/table-data.service.ts 84.61% <0.00%> (+6.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47065f6...a47244f. Read the comment docs.

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz merged commit f22024e into NG-ZORRO:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal: Old danger buttons still used
2 participants