Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:description): fix label colon not working #6155

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

yangjunhan
Copy link
Contributor

close #6151

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #6151

What is the new behavior?

[nzColon]="false" is now working.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Dec 7, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #6155 (293212d) into master (13f2281) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6155      +/-   ##
==========================================
+ Coverage   89.81%   89.84%   +0.02%     
==========================================
  Files         468      468              
  Lines       14258    14258              
  Branches     2243     2243              
==========================================
+ Hits        12806    12810       +4     
+ Misses        896      892       -4     
  Partials      556      556              
Impacted Files Coverage Δ
components/descriptions/descriptions.component.ts 100.00% <ø> (ø)
components/tabs/tab-nav-bar.component.ts 81.62% <0.00%> (-0.71%) ⬇️
components/core/util/text-measure.ts 91.30% <0.00%> (+1.73%) ⬆️
components/table/src/table-data.service.ts 84.61% <0.00%> (+6.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13f2281...293212d. Read the comment docs.

@hsuanxyz hsuanxyz merged commit 47065f6 into NG-ZORRO:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NzDescriptions - nzColon disable does not work
2 participants