Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:descriptions): fix DOM structure #6112

Merged
merged 1 commit into from
Nov 28, 2020

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Nov 28, 2020

close #6109

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Nov 28, 2020

Codecov Report

Merging #6112 (b170bf8) into master (167bf15) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6112      +/-   ##
==========================================
+ Coverage   89.84%   89.85%   +0.01%     
==========================================
  Files         465      465              
  Lines       14095    14095              
  Branches     2236     2236              
==========================================
+ Hits        12663    12665       +2     
+ Misses        881      878       -3     
- Partials      551      552       +1     
Impacted Files Coverage Δ
components/descriptions/descriptions.component.ts 100.00% <ø> (ø)
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️
components/table/src/table-data.service.ts 84.61% <0.00%> (+6.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 167bf15...b170bf8. Read the comment docs.

@vthinkxie vthinkxie merged commit 5e42d71 into NG-ZORRO:master Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Descriptions default layout style error, should align content horizontal
2 participants